Subject: Re: bin/166664: patch man devd to note /sbin/devd parses backward through devd. (fwd) From: "Julian H. Stacey" Date: Thu, 05 Apr 2012 12:55:02 +0200 To: Warner Losh Hi Warner, FYI as you are editor of man devd Cheers Julian ------- Forwarded Message From jhs@@@berklix.com Thu Apr 5 12:52:32 2012 Date: Thu, 5 Apr 2012 12:49:52 +0200 (CEST) Message-Id: <201204051049.q35Anq55008600@@@fire.js.berklix.net> To: FreeBSD-gnats-submit@@@freebsd.org Subject: patch man devd to note /sbin/devd parses backward through devd.conf From: "Julian H. Stacey" Reply-To: "Julian H. Stacey" Cc: "Julian H. Stacey" X-send-pr-version: 3.113 X-GNATS-Notify: >Submitter-Id: current-users >Originator: Julian H. Stacey >Organization: http://www.berklix.com BSD Linux Unix Consultancy, Munich/Muenchen. >Confidential: no >Synopsis: patch man devd to note /sbin/devd parses backward through devd.conf >Severity: non-critical >Priority: low >Category: bin >Class: change-request >Release: FreeBSD 8.2-RELEASE amd64 >Environment: System: FreeBSD fire.js.berklix.net 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Jun 2 23:10:13 CEST 2011 jhs@@@blak.js.berklix.net:/ad6s4/release/8.2-RELEASE/src/sys/amd64/compile/FIRE64.small amd64 >Description: patch man devd to note /sbin/devd parses backward through devd.conf >How-To-Repeat: Copy in my sample, Change to numbers of 2 similar products you have, & try it. Apply the patch. (delete the example if you want, it's primarily there to show the commiter a concrete example) >Fix: http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/generic/src/sbin/devd/ *** 8.2-RELEASE/src/sbin/devd/devd.8 Thu Apr 5 12:16:45 2012 --- new-generic/src/sbin/devd/devd.8 Thu Apr 5 12:29:41 2012 *************** *** 129,134 **** --- 129,166 ---- .Ux domain socket at .Pa /var/run/devd.pipe . + .Sh BUGS + .Pa /sbin/devd + parses backward (not forwards as a human editing + .Pa /etc/devd.conf + would intuitively expect), looking for a match. + .br + Example: zogi is seen as mueller, unless the lower sernum uncommented. + .in +2 + .nf + attach 1000 { # ZOGI name on case + match "vendor" "0x058f" ; + match "product" "0x6387" ; + match "sernum" "47F0CAFA" ; + match "release" "0x0103" ; + action "sleep 2; rm -f /devusb/zogi; \ + ln -s /dev/`echo $device-name|sed -e s/umass/da/`s1 /devusb/zogi;\ + fsck -y -t msdosfs /devusb/zogi; mkdir /usb/zogi ; \ + chmod 777 /usb/zogi ; mount -t msdosfs /devusb/zogi /usb/zogi" ; + }; + attach 1000 { # bought from Mueller + match "vendor" "0x058f" ; + match "product" "0x6387" ; + match "release" "0x0103" ; + # match "sernum" "67843FC2" ; + action "sleep 5 ; \ + rm -f /devusb/mueller ; \ + ln -s /dev/`echo $device-name|sed -e s/umass/da/`s1 /devusb/mueller; \ + mkdir /usb/mueller ; chmod 777 /usb/mueller ; \ + mount -t msdosfs /devusb/mueller /usb/mueller" ; + }; + .fi + .in -2 .Sh FILES .Bl -tag -width ".Pa /var/run/devd.pipe" -compact .It Pa /etc/devd.conf